Author Topic: cleaning up  (Read 414 times)

riccardo

  • Global Moderator
  • Newbie
  • *****
  • Posts: 47
cleaning up
« on: September 22, 2016, 05:51:06 PM »
Dear All,

i am taking a look into the trilinos application, and i believe that some cleanup is sorely needed.

to begin, if i look into the builder and solvers, i find this list

trilinos_block_builder_and_solver.h
trilinos_block_builder_and_solver_periodic.h
trilinos_builder_and_solver_ML_deactivation.h
trilinos_builder_and_solver_ML_deactivation_vec.h
trilinos_builder_and_solver_ML.h
trilinos_builder_and_solver_ML_mixed.h
trilinos_builder_and_solver_ML_periodic.h
trilinos_builder_and_solver_ML_vec.h
trilinos_multiphase_builder_and_solver.h
trilinos_pressure_splitting_builder_and_solver.h
trilinos_residualbased_elimination_builder_and_solver_componentwise_slip.h
trilinos_residualbased_elimination_builder_and_solver_deactivation.h
trilinos_residualbased_elimination_builder_and_solver.h



i believe that out of those only
trilinos_residualbased_elimination_builder_and_solver.h
trilinos_block_builder_and_solver.h
trilinos_block_builder_and_solver_periodic.h

should remain. I am aware that taking out the others would break some code, however the change to fallback to the short list above would me minor.

please let me know if you have any TECHNICAL concern about this removal. 

Please consider that i am aware that this will break old code...

regards
Riccardo


pooyan

  • Global Moderator
  • Newbie
  • *****
  • Posts: 33
Re: cleaning up
« Reply #1 on: September 23, 2016, 09:19:50 AM »
I agree with such a clean up as it reduces the duplicated codes and I am pretty sure that many of these classes are not used anymore. There are few people using MPI version so the damage is less pronounced. By the way I would suggest you to announce the change in mailing list.

Just to add, now that you are cleaning please drop the residaulbased from the name as all of them are residual based and only causes problem in opening the correct file because you only see half of the names.