Author Topic: Unify the geometry spliting methods  (Read 361 times)

vmataix

  • Newbie
  • *
  • Posts: 31
Unify the geometry spliting methods
« on: May 03, 2016, 03:19:31 PM »
I have a suggestion

I have unified the mesh local refiners recently, and I saw that the element splitting methods have not a common class (split_triangle.c, split_tetraedra.h and split_prism.hpp) and maybe could be a good idea to create a mother class that reunite all the geometry spliters.

pooyan

  • Global Moderator
  • Newbie
  • *****
  • Posts: 33
Re: Unify the geometry spliting methods
« Reply #1 on: May 11, 2016, 08:24:58 PM »
As we have talked about this verbally I just wanted to post here that we have decided to add a base class with all common parts of the refinement and derive classes for each type of geometries with corresponding implementation detail as Vicente suggested

pooyan

  • Global Moderator
  • Newbie
  • *****
  • Posts: 33
Re: Unify the geometry spliting methods
« Reply #2 on: May 12, 2016, 10:41:51 PM »
Can you please add the unit test for these classes?

Bests,

vmataix

  • Newbie
  • *
  • Posts: 31
Re: Unify the geometry spliting methods
« Reply #3 on: May 12, 2016, 11:18:25 PM »
I can, but not this week.